Skip to content

[WIP] Improvements for tape recording debug mode (e.g. zone-specific tags) #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oleburghardt wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

[WIP] Improvements for tape recording debug mode (e.g. zone-specific tags) #2721

oleburghardt wants to merge 20 commits into from
+253 −83

Conversation

@oleburghardt
Copy link
Contributor

@oleburghardt oleburghardt commented Jan 29, 2026 •
edited
Loading

Proposed Changes

Continuation of #2442.

Related Work

Primarily meant to check developments in #2446.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@oleburghardt
Change some simple functions in ad_structure.hpp belonging to the tap…
85ad370 
…e check functionality.
@oleburghardt
Changes in CDiscAdjMultizoneDriver.hpp for extension of the tape chec…
a25b871 
…k functionality.
@oleburghardt
Adding SetCurrentStatus to ad_structure.hpp for extension of the tape…
6bd7a48 
… check functionality.
@oleburghardt
Extend tagErrorCallback to transform tag mismatches into errors in a …
ec85644 
…more useful way.
@oleburghardt
Set the tagErrorCallback function via a AD::SetCallbackMode wrapper.
d27cbd7
@oleburghardt
Add CDiscAdjMultizoneDriver::TapeTestGetTag for zone-specific tags.
0d9a5e9
@oleburghardt
Main changes in CDiscAdjMultizoneDriver::TapeTest and CDiscAdjMultizo…
557299a 
…neDriver::SetRecording for zone-specific tags.
@oleburghardt
Merge branch 'develop' of https://github.com/su2code/SU2 into enhance…
e893ee7 
…ment_tape_debug_mode
@oleburghardt oleburghardt changed the base branch from master to develop January 29, 2026 14:01
oleburghardt added a commit that referenced this pull request Feb 4, 2026
@oleburghardt
Changes to the tape debug mode, improving the detection of errors whe…
b9b34ba 
…n recording wrt mesh coordinates.

The tape debug mode code is currently also reworked in #2721. The changes in this commit could already be useful for the current turbo discrete adjoint development.
@oleburghardt
Redefine CHECK_TAPE_VARIABLES as SOLUTION_VARIABLES and MESH_COORDS, …
1162b46 
…remove RECORDING::TAG_* options as they can, in fact, be avoided.
@oleburghardt
Register solution variables, too, when CHECK_TAPE_VARIABLES = MESH_CO…
cabe6e0 
…ORDS.
@oleburghardt
Move CDiscAdjMultizoneDriver::TapeTestGetTag to AD::GetTag.
25eca83
@oleburghardt
Follow-up removal of RECORDING_TAG* options.
5afe777
@oleburghardt
Renamings, transform AD::SetCallbackMode to AD::SetTapeDebugOption th…
935ddaf 
…at only sets the debug mode options.
@oleburghardt
Add AD::ActivateTagErrorCallback that sets the tag error callback fun…
12916b0 
…ction of the AD tape (debug mode).
@oleburghardt
Set init and check tags via SetTapeDebugOption (tape debug mode).
86f4508
@oleburghardt
Set multizone tags via SetTapeDebugOption (tape debug mode).
4e4d671
@oleburghardt
Fixes (tape debug mode).
ad14b50
@oleburghardt
Fix (tape debug mode).
61c5313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog:feature enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@oleburghardt